executor, infoschema: Add cluster_statements_summary_evicted table to TiDB #25418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance LRU cache, enable users access evicted key-value pair on Put() Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Release Note: enhanced LRU Cache some type fixes to cheat CI. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
typo fixes. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
enhance test on lru's Put() method. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Add a function property in kvcache; Add a method to kvcache; Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Used Gofmt Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
An initial commit, still cannot work properly. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Catch up with PingCAP Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
now we can see evicted count debug logging expressions not deleted... Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
STATEMENTS_SUMMARY_EVICTED now able to use Test will be added in tomorrow. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Purge logging code used for debugging. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
add test to evicted count, fix bugs in ssMap.other. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Add test to stmtSummaryByDigestMap.ToEvictedCountDatum and stmtSummaryByDigestEvictedElement.ToEvictedCountDatum. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
make disable fail-point Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
� Conflicts: � executor/infoschema_reader.go � infoschema/tables.go
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
focus on evicted count and purged unrelated contents. Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
improve AddEvicted() from O(mn) to O(n) typo fixs Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
|
/run-all-tests |
|
/cc @crazycs520 |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: cff70d7
|
ti-chi-bot
added
the
status/can-merge
|
cherry pick to release-5.1 in PR #25587 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 21, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 21, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #25588 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 21, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #25590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
I have added
statements_summary_evictedtable to TiDB in #24513, a month ago. However, I didn't add this feature for cluster information.This PR added the feature of adding cluster information of evicted count.
What is changed and how it works?
What's Changed:
Inforschema and executor.
How it Works:
Added a new table:
information_schema.cluster_statements_summary_evictedto TiDB.Related changes
Check List
Tests
Side effects
Release note